Updating IOUtils.toCanonicalFilePath to work in a spring boot application #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cloned the project at https://github.com/maxmin93/agens-spark to test this. I realized that the problem is more than just that it's a jar with in a jar -- it is also complicated by the fact that Spring Boot provides its own custom URLStreamHandler. That URLStreamHandler results in the URLConnection returning a different jar file URL than the default one. I added a unit test to simulate what the spring boot one does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so that es-hadoop does not blow up when it is packaged within a Spring Boot application.
Closes #1359