Skip to content

Eventstream Refactor #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bretambrose merged 80 commits into from
Aug 8, 2025
Merged

Eventstream Refactor #816

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
d3e49b0
Initial resolution attempt
Apr 11, 2025
a99cd1e
Update
Apr 11, 2025
904651a
Testing
Apr 14, 2025
bb948aa
Pre-format sync
Apr 14, 2025
8403ed4
Updated format script
Apr 14, 2025
1160d10
Update formatting to python-based with clang version control
Apr 15, 2025
b4d3bcd
Update to builder version with eventstream server support
Apr 15, 2025
21abfcd
Credentials setup
Apr 15, 2025
4df20ff
Cleanup strings per fixture tear down
Apr 15, 2025
6c0184c
Try ubuntu 22 to see if maven is pre-installed
Apr 15, 2025
e6fbe72
No allocator exists during static initialization
Apr 21, 2025
8f2417e
Begin test rewrite; failures on other platforms should reveal other t…
Apr 22, 2025
5c3ccfc
Includes
Apr 22, 2025
a1b918a
Use latest configure credentials to see if retries avoid baffling error
Apr 22, 2025
a571695
Widen failure possibility based on CI
Apr 22, 2025
9c5dd02
Custom eventstream server step so that we can dump server-side logs f…
Apr 23, 2025
8639e71
Install maven during setup
Apr 23, 2025
8085d1a
Try to gather output that tells us whether the Java CRT is supported …
Apr 23, 2025
cf79be3
Check stderr of eventstream run to verify platform Java CRT support
Apr 23, 2025
440c493
print stderr
Apr 23, 2025
e8f00fd
Why is everything failing now?
Apr 23, 2025
d80780f
Don't route stdout to stdout
Apr 23, 2025
121dc44
Missing import
Apr 23, 2025
7c7f7cd
Probe command log
Apr 23, 2025
2028eac
Updates
Apr 23, 2025
231e4f4
Umm let's not cause tsan warnings by blindly unlocking stuff
Apr 23, 2025
cc7afc7
Formatting fix (but don't check in format update yet) + more test work
Apr 24, 2025
cd9289c
Formatting and codegen updates
Apr 24, 2025
34b1e29
More tests
Apr 25, 2025
42eb9b5
Merge branch 'main' into EventstreamDestructionDeadlock
Apr 25, 2025
1d02362
Weird x86 compile error
Apr 25, 2025
7cdbd39
Checkpoint before refactoring impl
May 8, 2025
8079f33
Checkpoint
May 14, 2025
180f150
Fixes
May 15, 2025
83b950e
Checkpoint
May 20, 2025
6f6b0e1
Misc rewrite
May 20, 2025
64032b5
Clients now track connection by shared pointer
May 21, 2025
37291b9
Checkpoint
May 30, 2025
422f315
Remove ifdefd out stuff
May 30, 2025
cdb0a7a
Outbound streaming
Jun 2, 2025
a217ded
Checkpoint before branching
Jun 6, 2025
b434249
Full synthetic callback solution
Jun 13, 2025
2c4b72f
Streaming success tests
Jun 16, 2025
8187524
Final stress testing
Jun 18, 2025
94c78c9
Remove operation context subclasses from public API
Jun 19, 2025
5e9d2ce
Merge branch 'main' into EventstreamRefactor2
Jun 19, 2025
9552449
Commentary
Jun 20, 2025
afafd85
Update CRT version
Jun 24, 2025
b13a1e2
Structure init
Jun 24, 2025
9bd481d
Missing include
Jun 24, 2025
ba9a4bf
Unused params & missing casts
Jun 24, 2025
c68b8c7
Let's not do CI setup twice
Jun 24, 2025
abeac6d
Merge branch 'main' into EventstreamRefactor2
Jun 24, 2025
84b5f80
Sigh
Jun 24, 2025
b49cb82
Oops
Jun 24, 2025
5dcb813
More logging
Jun 24, 2025
b36a824
Don't grab a raw c string managed by a temporary
Jun 24, 2025
df48929
Apply Igor's old eventstream cleanup changes
Jun 24, 2025
a0282c9
clang-tidy codegen updates
Jun 25, 2025
8ccccb2
Small fixes before result refactor
Jul 11, 2025
d563648
Refactor result to be a Crt::Variant; don't send terminate stream whe…
Jul 14, 2025
72e869b
Use safe cast which isn't yet available in released CRT
Jul 17, 2025
0d59874
Submodule update
bretambrose Jul 17, 2025
2f641c4
Weird compiler error
Jul 17, 2025
bcc09fc
Wish this was rust
bretambrose Jul 18, 2025
1ba1314
Fix some race conditions and use client connection refactor
Aug 1, 2025
2c80e3c
Test relaxation plus logging for windows failures
Aug 2, 2025
8fd8944
Allow close rpc status for Windows
Aug 2, 2025
3291633
Switch to std::variant for diagnosis
Aug 3, 2025
8b7b440
Switch off Crt::Variant temporarily
bretambrose Aug 5, 2025
831d595
Pull in Igor's ci changes
bretambrose Aug 5, 2025
9bb9cdb
Volume
bretambrose Aug 5, 2025
0d68aef
Wip double free
bretambrose Aug 5, 2025
922002a
Try #2 at connect amendment fixup
bretambrose Aug 6, 2025
8dde24d
Start logging why timestamp fails
bretambrose Aug 6, 2025
f241b9c
Update to tagged release
Aug 6, 2025
74c4faf
Merge branch 'main' into EventstreamRefactor2
Aug 8, 2025
e2e3749
PR feedback:
Aug 8, 2025
244bb7b
Sigh Windows
Aug 8, 2025
a84916a
Grumble
Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Begin test rewrite; failures on other platforms should reveal other t… 
…erminal status codes
  • Loading branch information
Bret Ambrose committed Apr 22, 2025
commit 8f2417e42749c515479d4b9b950e5fa580640647
13 changes: 9 additions & 4 deletions eventstream_rpc/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,16 @@ file(GLOB TESTS ${TEST_HDRS} ${TEST_SRC})

set(TEST_BINARY_NAME ${PROJECT_NAME}-tests)

add_test_case(OperateWhileDisconnected)
add_test_case(EventStreamConnectSuccess)
add_test_case(EventStreamConnectFailureNoAuthHeader)
add_test_case(EventStreamConnectFailureBadAuthHeader)
add_test_case(EchoClientConnectSuccess)

#add_test_case(OperateWhileDisconnected)
# The tests below can be commented out when an EchoRPC Server is running on 127.0.0.1:8033
add_test_case(EventStreamConnect)
add_test_case(EchoOperation)
add_test_case(StressTestClient)
#add_test_case(EventStreamConnect)
#add_test_case(EchoOperation)
#add_test_case(StressTestClient)
generate_cpp_test_driver(${TEST_BINARY_NAME})
aws_add_sanitizers(${TEST_BINARY_NAME})
target_include_directories(${TEST_BINARY_NAME} PUBLIC
Expand Down
Loading
Loading