projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 10fb48d) | patch
Fix misuse of TextDatumGetCString().
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Jul 2015 21:02:08 +0000 (17:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Jul 2015 21:02:08 +0000 (17:02 -0400)
commitac50f84866b22f239025bf37c9c7492cc4ce2dfd
tree79827f62e9d4752457fc813b09d122d864794d0atree
parent10fb48d66de76e7dc1e36ef18af502ed9600352fcommit | diff
Fix misuse of TextDatumGetCString().

"TextDatumGetCString(PG_GETARG_TEXT_P(x))" is formally wrong: a text*
is not a Datum.  Although this coding will accidentally fail to fail on
all known platforms, it risks leaking memory if a detoast step is needed,
unlike "TextDatumGetCString(PG_GETARG_DATUM(x))" which is what's used
elsewhere.  Make pg_get_object_address() fall in line with other uses.

Noted while reviewing two-arg current_setting() patch.
src/backend/catalog/objectaddress.c diff | blob | blame | history
This is the main PostgreSQL git repository.