projects / users / kgrittn / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 409b8c7) | patch
Avoid platform-dependent infinite loop in pg_dump.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Nov 2011 21:08:14 +0000 (16:08 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Nov 2011 21:09:01 +0000 (16:09 -0500)
commitcf22e851b6ae8737f3e767dffcadf1722fbb36a7
tree28672f5691aa325398dd653d3b3df9498fa930cftree
parent409b8c75ba71fe6f3a7f9ccc094810966ef3a177commit | diff
Avoid platform-dependent infinite loop in pg_dump.

If malloc(0) returns NULL, the binary search in findSecLabels() will
probably go into an infinite loop when there are no security labels,
because NULL-1 is greater than NULL after wraparound.

(We've seen this pathology before ... I wonder whether there's a way to
detect the class of bugs automatically?)

Diagnosis and patch by Steve Singer, cosmetic adjustments by me
src/bin/pg_dump/pg_dump.c diff | blob | blame | history
Kevin Grittner's development, especially fully serializable transactions (See http://wiki.postgresql.org/wiki/Serializable for more info)