From d981160bd5afd9112ea9ca38eb490e14f0b17bee Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Thu, 5 Jul 2018 16:51:00 +0200 Subject: [PATCH] Don't allow textchoices on numeric answers in feedback setup --- postgresqleu/confreg/backendforms.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/postgresqleu/confreg/backendforms.py b/postgresqleu/confreg/backendforms.py index 91c966c..d761910 100644 --- a/postgresqleu/confreg/backendforms.py +++ b/postgresqleu/confreg/backendforms.py @@ -579,6 +579,13 @@ class BackendFeedbackQuestionForm(BackendForm): 'Sortkey': ['nosearch' ], } + def clean(self): + cleaned_data = super(BackendFeedbackQuestionForm, self).clean() + if not self.cleaned_data.get('isfreetext', 'False'): + if self.cleaned_data.get('textchoices', ''): + self.add_error('textchoices', 'Textchoices can only be specified for freetext fields') + return cleaned_data + @classmethod def copy_from_conference(self, targetconf, sourceconf, idlist): # Conference feedback questions are copied straight over, but we disallow duplicates -- 2.39.5