Allow resetting unknown custom GUCs with reserved prefixes.
authorNathan Bossart <nathan@postgresql.org>
Fri, 1 Aug 2025 21:52:11 +0000 (16:52 -0500)
committerNathan Bossart <nathan@postgresql.org>
Fri, 1 Aug 2025 21:52:11 +0000 (16:52 -0500)
commit39ff056365e438b530498def7ef18d588129e8e0
tree5e348df8897fba6d6fd375348e9d42594f76f310
parent8c298324a4f3c26138b3d31248e6bd9d627963b5
Allow resetting unknown custom GUCs with reserved prefixes.

Currently, ALTER DATABASE/ROLE/SYSTEM RESET [ALL] with an unknown
custom GUC with a prefix reserved by MarkGUCPrefixReserved() errors
(unless a superuser runs a RESET ALL variant).  This is problematic
for cases such as an extension library upgrade that removes a GUC.
To fix, simply make sure the relevant code paths explicitly allow
it.  Note that we require superuser or privileges on the parameter
to reset it.  This is perhaps a bit more restrictive than is
necessary, but it's not clear whether further relaxing the
requirements is safe.

Oversight in commit 88103567cb.  The ALTER SYSTEM fix is dependent
on commit 2d870b4aef, which first appeared in v17.  Unfortunately,
back-patching that commit would introduce ABI breakage, and while
that breakage seems unlikely to bother anyone, it doesn't seem
worth the risk.  Hence, the ALTER SYSTEM part of this commit is
omitted on v15 and v16.

Reported-by: Mert Alev <mert@futo.org>
Reviewed-by: Laurenz Albe <laurenz.albe@cybertec.at>
Discussion: https://postgr.es/m/18964-ba09dea8c98fccd6%40postgresql.org
Backpatch-through: 15
contrib/auto_explain/Makefile
contrib/auto_explain/expected/alter_reset.out [new file with mode: 0644]
contrib/auto_explain/meson.build
contrib/auto_explain/sql/alter_reset.sql [new file with mode: 0644]
src/backend/utils/misc/guc.c