WAL-log inplace update before revealing it to other sessions.
authorNoah Misch <noah@leadboat.com>
Fri, 25 Oct 2024 13:51:03 +0000 (06:51 -0700)
committerNoah Misch <noah@leadboat.com>
Fri, 25 Oct 2024 13:51:08 +0000 (06:51 -0700)
commitacf49584e2165ded5396d107961b568fe8f5f954
tree0f72ba7113949808267a66120e1a87b6ef299531
parente3914bd136e467b3af7e5a334e0e753df2a13f53
WAL-log inplace update before revealing it to other sessions.

A buffer lock won't stop a reader having already checked tuple
visibility.  If a vac_update_datfrozenid() and then a crash happened
during inplace update of a relfrozenxid value, datfrozenxid could
overtake relfrozenxid.  That could lead to "could not access status of
transaction" errors.  Back-patch to v12 (all supported versions).  In
v14 and earlier, this also back-patches the assertion removal from
commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b.

Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com
src/backend/access/heap/README.tuplock
src/backend/access/heap/heapam.c
src/backend/access/transam/xloginsert.c