Fix assertion failure when running pgbench -s.
authorFujii Masao <fujii@postgresql.org>
Thu, 7 Nov 2019 07:31:36 +0000 (16:31 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 7 Nov 2019 07:33:47 +0000 (16:33 +0900)
commitb1bebc2cee58569619c3b9e3050c5fb8dcc1b141
tree2e0bbd45517af79bef79e3761f952b21acfa283f
parent404d25f3c5494db139a6898937c4d1072d085e2d
Fix assertion failure when running pgbench -s.

If there is the WAL page that the continuation WAL record just fits within
(i.e., the continuation record ends just at the end of the page) and
the LSN in such page is specified with -s option, previously pg_waldump
caused an assertion failure. The cause of this assertion failure was that
XLogFindNextRecord() that pg_waldump -s calls mistakenly handled
such special WAL page.

This commit changes XLogFindNextRecord() so that it can handle
such WAL page correctly.

Back-patch to all supported versions.

Author: Andrey Lepikhov
Reviewed-by: Fujii Masao, Michael Paquier
Discussion: https://postgr.es/m/99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru
src/backend/access/transam/xlogreader.c