pg_dump: Fix dumping of security labels on subscriptions and event triggers.
authorFujii Masao <fujii@postgresql.org>
Tue, 16 Sep 2025 07:44:58 +0000 (16:44 +0900)
committerFujii Masao <fujii@postgresql.org>
Tue, 16 Sep 2025 07:47:05 +0000 (16:47 +0900)
commitdff7591a7041b4ccbb42806c6492a29d86fece86
treeb7f307d69e4ce9a9deb8ebc044bda6e1a0ffcffa
parent8fbd1f8ea2e14a1ac1d16a7d90d301833c76e273
pg_dump: Fix dumping of security labels on subscriptions and event triggers.

Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels
for subscriptions, which are stored in pg_shseclabel as they are global objects.
This could result in security labels for subscriptions not being dumped.

This commit fixes the issue by updating pg_dump to query the pg_seclabels view,
which aggregates entries from both pg_seclabel and pg_shseclabel.
While querying pg_shseclabel directly for subscriptions was an alternative,
using pg_seclabels is simpler and sufficient.

In addition, pg_dump is updated to dump security labels on event triggers,
which were previously omitted.

Backpatch to all supported versions.

Author: Jian He <jian.universality@gmail.com>
Co-authored-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
Backpatch-through: 13
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_dump.c