From: Tatsuo Ishii <ishii@postgresql.org>
Date: Wed, 13 Nov 2024 06:28:06 +0000 (+0900)
Subject: Fix authentication failure after updating pool_passwd and reload.
X-Git-Tag: V4_6_0_BETA1~31
X-Git-Url: http://git.postgresql.org/gitweb/static/benefitdownload/file?a=commitdiff_plain;h=06f4f0894712cb4fa5f228e4959c7af8f1dfe9f2;p=pgpool2.git

Fix authentication failure after updating pool_passwd and reload.

If pool_hba.conf is disabled, updating pool_passwd was not recognized
by pgpool child process even if pgpool reload was performed.  The
reload processing function check_config_reload() mistakenly assumed
that reopening pool_passwd was only necessary when enable_pool_hba is
on.

Backpatch-through: v4.1
Discussion: https://www.pgpool.net/pipermail/pgpool-general/2024-November/001944.html
---

diff --git a/src/protocol/child.c b/src/protocol/child.c
index ee7437770..53a4cce68 100644
--- a/src/protocol/child.c
+++ b/src/protocol/child.c
@@ -1805,9 +1805,10 @@ check_config_reload(void)
 		if (pool_config->enable_pool_hba)
 		{
 			load_hba(get_hba_file_name());
-			if (strcmp("", pool_config->pool_passwd))
-				pool_reopen_passwd_file();
 		}
+		if (strcmp("", pool_config->pool_passwd))
+			pool_reopen_passwd_file();
+
 		got_sighup = 0;
 	}
 }