Fix walsender error cleanup code
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 15 May 2020 23:59:29 +0000 (19:59 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Sat, 16 May 2020 00:00:52 +0000 (20:00 -0400)
commit1d3743023ef8fa665902e791b0d52e9a1ab419cb
tree7cf3a1fb6c6c2cf21a342beaf33cc662af4d01ec
parent14a91010912632cae322b06fce0425faedcf7353
Fix walsender error cleanup code

In commit 850196b610d2 I (Álvaro) failed to handle the case of walsender
shutting down on an error before setting up its 'xlogreader' pointer;
the error handling code dereferences the pointer, causing a crash.
Fix by testing the pointer before trying to dereference it.

Kyotaro authored the code fix; I adopted Nathan's test case to be used
by the TAP tests and added the necessary PostgresNode change.

Reported-by: Nathan Bossart <bossartn@amazon.com>
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/C04FC24E-903D-4423-B312-6910E4D846E5@amazon.com
src/backend/replication/walsender.c
src/test/perl/PostgresNode.pm
src/test/recovery/t/006_logical_decoding.pl