Fix misuse of table_index_fetch_tuple_check().
authorPeter Geoghegan <pg@bowt.ie>
Thu, 25 Jun 2020 17:55:26 +0000 (10:55 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Thu, 25 Jun 2020 17:55:26 +0000 (10:55 -0700)
commit8c2010f12344ed8834c6f63406a78e5843ebec69
tree58914891612ea35fc1f26028ca793491efd0640e
parent185c6bc4aef1201b7d0f2c4e9c8893c4a663dfd4
Fix misuse of table_index_fetch_tuple_check().

Commit 0d861bbb, which added deduplication to nbtree, had
_bt_check_unique() pass a TID to table_index_fetch_tuple_check() that
isn't safe to mutate.  table_index_fetch_tuple_check()'s tid argument is
modified when the TID in question is not the latest visible tuple in a
hot chain, though this wasn't documented.

To fix, go back to using a local copy of the TID in _bt_check_unique(),
and update comments above table_index_fetch_tuple_check().

Backpatch: 13-, where B-Tree deduplication was introduced.
src/backend/access/nbtree/nbtinsert.c
src/backend/access/table/tableam.c
src/include/access/tableam.h