Fix bug in release_connection() introduced by d9f45c9018
authorTomas Vondra <tomas@2ndquadrant.com>
Tue, 7 Nov 2017 17:34:55 +0000 (18:34 +0100)
committerTomas Vondra <tomas@2ndquadrant.com>
Tue, 7 Nov 2017 17:34:55 +0000 (18:34 +0100)
commit3d19f5b035714899820e4cfffca3944bfadc20af
treefab27fbc7297c4283194597d198f9aebe78f8877
parenta59901be0f488c2071aea53e3f6d3f2eb9a86f03
Fix bug in release_connection() introduced by d9f45c9018

d9f45c9018ec3ec1fc11e4be2be7f9728a1799b1 attempted to refactor
release_connection() to make it more readable, but unfortunately
inverted the force_destroy check, causing regression failures.

In hindsight, the refactoring was rather arbitrary and not really
helping with the readability, so just revert to the original code
(but keep the comments, explaining what's happening).
src/backend/pgxc/pool/poolmgr.c