Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 May 2020 20:01:52 +0000 (16:01 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 May 2020 20:07:30 +0000 (16:07 -0400)
commit3e9744465dbe51822c7d76baca1f934d54ba9452
tree08526408599e7a83c122462413f793c0531576f4
parent6a918c3ac8a6b1d8b53cead6fcb7cbd84eee5750
Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS

Use it at level 4, a bit more restrictive than the default level, and
tweak our commanding comments to FALLTHROUGH.

(However, leave zic.c alone, since it's external code; to avoid the
warnings that would appear there, change CFLAGS for that file in the
Makefile.)

Author: Julien Rouhaud <rjuju123@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20200412081825.qyo5vwwco3fv4gdo@nol
Discussion: https://postgr.es/m/flat/E1fDenm-0000C8-IJ@gemulon.postgresql.org
33 files changed:
configure
configure.in
src/backend/access/heap/heapam_handler.c
src/backend/catalog/dependency.c
src/backend/commands/tablecmds.c
src/backend/commands/trigger.c
src/backend/executor/nodeHash.c
src/backend/executor/nodeHashjoin.c
src/backend/executor/nodeLimit.c
src/backend/libpq/auth.c
src/backend/optimizer/util/clauses.c
src/backend/parser/parse_utilcmd.c
src/backend/partitioning/partprune.c
src/backend/postmaster/postmaster.c
src/backend/regex/regc_pg_locale.c
src/backend/replication/logical/reorderbuffer.c
src/backend/replication/walreceiver.c
src/backend/replication/walreceiverfuncs.c
src/backend/tcop/utility.c
src/backend/utils/adt/formatting.c
src/backend/utils/adt/jsonb_util.c
src/backend/utils/adt/timestamp.c
src/backend/utils/adt/tsginidx.c
src/backend/utils/hash/dynahash.c
src/backend/utils/mb/mbutils.c
src/backend/utils/misc/guc.c
src/common/hashfn.c
src/common/wchar.c
src/interfaces/ecpg/pgtypeslib/interval.c
src/interfaces/libpq/fe-secure.c
src/pl/plpgsql/src/pl_exec.c
src/port/snprintf.c
src/timezone/Makefile