pgbench: Fix assertion failure with retriable errors in pipeline mode.
authorFujii Masao <fujii@postgresql.org>
Fri, 26 Sep 2025 12:23:43 +0000 (21:23 +0900)
committerFujii Masao <fujii@postgresql.org>
Fri, 26 Sep 2025 12:23:43 +0000 (21:23 +0900)
commit8bb174295e8920fe202e2fb4c8d271e4546b9e98
treecc1adf758b5375a8ef1620b171cb497c1038be0a
parent85e0ff62b68224b3354e47fb71b78d309063d06c
pgbench: Fix assertion failure with retriable errors in pipeline mode.

When running pgbench with --verbose-errors option and a custom script that
triggered retriable errors (e.g., serialization errors) in pipeline mode,
an assertion failure could occur:

    Assertion failed: (sql_script[st->use_file].commands[st->command]->type == 1), function commandError, file pgbench.c, line 3062.

The failure happened because pgbench assumed these errors would only occur
during SQL commands, but in pipeline mode they can also happen during
\endpipeline meta command.

This commit fixes the assertion failure by adjusting the assertion check to
allow such errors during either SQL commands or \endpipeline.

Backpatch to v15, where the assertion check was introduced.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwGWQMOzNkQs-LmpDHdNC0h8dmAuUMRvZrEntQi5a-b=Kg@mail.gmail.com
src/bin/pgbench/pgbench.c