Move various prechecks from vacuum() into ExecVacuum()
authorDavid Rowley <drowley@postgresql.org>
Thu, 6 Apr 2023 03:44:52 +0000 (15:44 +1200)
committerDavid Rowley <drowley@postgresql.org>
Thu, 6 Apr 2023 03:44:52 +0000 (15:44 +1200)
commitb9b125b9c14381c4d04a446e335bb2da5f602596
treef162a5dbeca3bb9ec0de3720a25320d48960215e
parentacab1b0914e426d28789731f50f5964dd4d2f054
Move various prechecks from vacuum() into ExecVacuum()

vacuum() is used for both the VACUUM command and for autovacuum. There
were many prechecks being done inside vacuum() that were just not relevant
to autovacuum.  Let's move the bulk of these into ExecVacuum() so that
they're only executed when running the VACUUM command.  This removes a
small amount of overhead when autovacuum vacuums a table.

While we are at it, allocate VACUUM's BufferAccessStrategy in ExecVacuum()
and pass it into vacuum() instead of expecting vacuum() to make it if it's
not already made by the calling function.  To make this work, we need to
create the vacuum memory context slightly earlier, so we now need to pass
that down to vacuum() so that it's available for use in other memory
allocations.

Author: Melanie Plageman
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/20230405211534.4skgskbilnxqrmxg@awork3.anarazel.de
src/backend/commands/vacuum.c
src/backend/postmaster/autovacuum.c
src/include/commands/vacuum.h