Fix "ignoring return value" complaints from commit 96d1f423f9
authorJoe Conway <mail@joeconway.com>
Sat, 4 Jul 2020 17:47:07 +0000 (13:47 -0400)
committerJoe Conway <mail@joeconway.com>
Sat, 4 Jul 2020 17:47:07 +0000 (13:47 -0400)
commitc536da177cbbc9e30de17a0a445b53d79a5bbe7f
tree77584877e53e07ace29b5304d847af8311b53ee5
parent0025c3a2c295459002711e0b37e48e3b067a83ba
Fix "ignoring return value" complaints from commit 96d1f423f9

The cfbot and some BF animals are complaining about the previous
read_binary_file commit because of ignoring return value of ‘fread’.
So let's make everyone happy by testing the return value even though
not strictly needed.

Reported by Justin Pryzby, and suggested patch by Tom Lane. Backpatched
to v11 same as the previous commit.

Reported-By: Justin Pryzby
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/flat/969b8d82-5bb2-5fa8-4eb1-f0e685c5d736%40joeconway.com
Backpatch-through: 11
src/backend/utils/adt/genfile.c