Make docs comment suggestions do a redirect
authorMagnus Hagander <magnus@hagander.net>
Mon, 28 Jan 2019 13:06:29 +0000 (14:06 +0100)
committerMagnus Hagander <magnus@hagander.net>
Mon, 28 Jan 2019 13:19:12 +0000 (14:19 +0100)
This is the same as b2ed4946551c098079d1a156b222d4ebf5c85cba did for bug
reports.

This changes the regexps for all the doc comment suggestions forms to be
a little bit more specific than before.

pgweb/account/urls.py
pgweb/docs/views.py

index 293836de636d6735e0e07025d933fc0ede7c992b..2a6f57e4ef59d20de8619880d79f96915e35f6d6 100644 (file)
@@ -37,7 +37,8 @@ urlpatterns = [
     url(r'^services/(.*)/$', pgweb.profserv.views.profservform),
 
     # Docs comments
-    url(r'^comments/(new)/(.*)/(.*)/$', pgweb.docs.views.commentform),
+    url(r'^comments/(new)/([^/]+)/([^/]+)/$', pgweb.docs.views.commentform),
+    url(r'^comments/(new)/([^/]+)/([^/]+)/done/$', pgweb.docs.views.commentform_done),
 
     # Log in, logout, change password etc
     url(r'^login/$', pgweb.account.views.login),
index db1ae5e0f367e4619deb082903ea8a409e7bca8f..4577f0ce0e37f9503ad216d3011e0cc0dd4b4ade 100644 (file)
@@ -171,7 +171,7 @@ def commentform(request, itemid, version, filename):
                 replyto='%s, %s' % (form.cleaned_data['email'], settings.DOCSREPORT_EMAIL),
                 sendername='PG Doc comments form'
             )
-            return render_pgweb(request, 'docs', 'docs/docsbug_completed.html', {})
+            return HttpResponseRedirect("done/")
     else:
         form = DocCommentForm(initial={
             'name': '%s %s' % (request.user.first_name, request.user.last_name),
@@ -187,3 +187,8 @@ def commentform(request, itemid, version, filename):
         }),
         'savebutton': 'Send Email',
     })
+
+
+@login_required
+def commentform_done(request, itemid, version, filename):
+    return render_pgweb(request, 'docs', 'docs/docsbug_completed.html', {})