Fix the failover() so that it does not access out of array.

Per Coverity.

diff --git a/src/main/pgpool_main.c b/src/main/pgpool_main.c
index f7591da2006da0de51bcf4361e2613fb389820f3..2eeeb40c1d5d5d82ff5472245513fc9eda9e354b 100644 (file)
--- a/src/main/pgpool_main.c
+++ b/src/main/pgpool_main.c
@@ -2025,6 +2025,7 @@ static void failover(void)
                        {
                                /* only if the failover is against the current primary */
                                if (((reqkind == NODE_DOWN_REQUEST) &&
+                                        Req_info->primary_node_id >= 0 &&
                                         (nodes[Req_info->primary_node_id])) ||
                                        (node_id >= 0 && (reqkind == PROMOTE_NODE_REQUEST) &&
                                         (VALID_BACKEND(node_id))))