Fix docs comment form for version = "current"
authorMagnus Hagander <magnus@hagander.net>
Mon, 28 Jan 2019 13:00:29 +0000 (14:00 +0100)
committerMagnus Hagander <magnus@hagander.net>
Mon, 28 Jan 2019 13:19:12 +0000 (14:19 +0100)
Normally not reachable with "current", only with explicit version,
but as proven by some live crashes, there is some way to. So make
sure we look up the current version instead of crashing.

pgweb/docs/views.py

index 2bfec6840ca49132ee092c590cc60fec3c5ec4da..db1ae5e0f367e4619deb082903ea8a409e7bca8f 100644 (file)
@@ -143,7 +143,10 @@ def manualarchive(request):
 
 @login_required
 def commentform(request, itemid, version, filename):
-    v = get_object_or_404(Version, tree=version)
+    if version == 'current':
+        v = Version.objects.get(current=True)
+    else:
+        v = get_object_or_404(Version, tree=version)
     if not v.supported:
         # No docs comments on unsupported versions
         return HttpResponseRedirect("/docs/{0}/{1}".format(version, filename))