From 5badd2035947e73b8a1a36a654eb9b38f4749cdb Mon Sep 17 00:00:00 2001 From: Tatsuo Ishii Date: Sun, 14 Feb 2021 09:41:15 +0900 Subject: [PATCH] Fix pcp_node_info() in pgpool_adm extension. The weight info was mistakenly handled by Float8GetDatum although the function prototype is float4. The oversight made the weight value to 0 or certain insane value. Change it to Float4GetDatum. It is amazing that nobody (including me) did not notice it until today. --- src/sql/pgpool_adm/pgpool_adm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sql/pgpool_adm/pgpool_adm.c b/src/sql/pgpool_adm/pgpool_adm.c index de94d49c7..fbbe4f08a 100644 --- a/src/sql/pgpool_adm/pgpool_adm.c +++ b/src/sql/pgpool_adm/pgpool_adm.c @@ -3,7 +3,7 @@ * pgpool_adm.c * * - * Copyright (c) 2002-2015, PostgreSQL Global Development Group + * Copyright (c) 2002-2021, PostgreSQL Global Development Group * * Author: Jehan-Guillaume (ioguix) de Rorthais * @@ -197,7 +197,7 @@ _pcp_node_info(PG_FUNCTION_ARGS) break; } nulls[2] = false; - values[3] = Float8GetDatum(backend_info->backend_weight/RAND_MAX); + values[3] = Float4GetDatum(backend_info->backend_weight / RAND_MAX); nulls[3] = false; pcp_disconnect(pcpConnInfo); -- 2.39.5