From a4736959ca631ec517d2bf36f90d43405268b2b7 Mon Sep 17 00:00:00 2001
From: Yugo Nagata <nagata@sraoss.co.jp>
Date: Fri, 20 Feb 2015 14:27:41 +0900
Subject: [PATCH] Fix to use void * for receiving return value of thread
 function

Previously int was used and this could occur stack buffer overflow.
This caused an infinity loop of ping error at bringing up or down
VIP, since a loop variable in a for loop was overwritten to zero.
---
 watchdog/wd_ping.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/watchdog/wd_ping.c b/watchdog/wd_ping.c
index e3fc42c78..a125ada71 100644
--- a/watchdog/wd_ping.c
+++ b/watchdog/wd_ping.c
@@ -109,14 +109,14 @@ wd_is_upper_ok(char * server_list)
 	pthread_attr_destroy(&attr);
 	for (i=0; i <cnt; )
 	{
-		int result;
-		rc = pthread_join(thread[i], (void **)&result);
+		void * result;
+		rc = pthread_join(thread[i], &result);
 		if ((rc != 0) && (errno == EINTR))
 		{
 			usleep(100);
 			continue;
 		}
-		if (result == WD_OK)
+		if (result == (void *)WD_OK)
 		{
 			rtn = WD_OK;
 		}
@@ -138,7 +138,7 @@ wd_is_unused_ip(char * ip)
 	WdInfo thread_arg;
 
 	int rtn = WD_NG;
-	int result;
+	void * result;
 
 	if (ip == NULL)
 	{
@@ -155,12 +155,12 @@ wd_is_unused_ip(char * ip)
 	rc = pthread_create(&thread, &attr, exec_ping, (void*)&thread_arg);
 	pthread_attr_destroy(&attr);
 
-	rc = pthread_join(thread, (void **)&result);
+	rc = pthread_join(thread, &result);
 	if ((rc != 0) && (errno == EINTR))
 	{
 		return WD_NG;
 	}
-	if (result == WD_NG)
+	if (result == (void *)WD_NG)
 	{
 		rtn = WD_OK;
 	}
-- 
2.39.5