From af21a22b818130cc0dae61900c631c591e9d55dd Mon Sep 17 00:00:00 2001 From: Tatsuo Ishii Date: Sat, 9 Nov 2024 15:34:57 +0900 Subject: [PATCH] Revert "Fix Pgpool-II child process crash during shutdown." This reverts commit 6dd66297db3acc5a9af4eb43ba7b5037102a8f0e. Per discussion: [pgpool-general: 9265] Re: Segmentation fault during shutdown https://www.pgpool.net/pipermail/pgpool-general/2024-November/001942.html --- src/protocol/child.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/protocol/child.c b/src/protocol/child.c index 5d50619de..b817e5820 100644 --- a/src/protocol/child.c +++ b/src/protocol/child.c @@ -1307,12 +1307,9 @@ child_will_go_down(int code, Datum arg) memcached_disconnect(); } - /* - * We used to call close_all_backend_connections() here so that we send - * 'X' (terminate) message to backend. However it was possible that the - * function is called while initializing the connection pool object, which - * leads to crash. So we stopped to call close_all_backend_connections(). - */ + /* let backend know now we are exiting */ + if (pool_connection_pool) + close_all_backend_connections(); } void child_exit(int code) -- 2.39.5