jit: Fix jit_profiling_support when unavailable. master github/master
authorThomas Munro <tmunro@postgresql.org>
Wed, 31 Dec 2025 00:24:17 +0000 (13:24 +1300)
committerThomas Munro <tmunro@postgresql.org>
Wed, 31 Dec 2025 01:50:23 +0000 (14:50 +1300)
jit_profiling_support=true captures profile data for Linux perf.  On
other platforms, LLVMCreatePerfJITEventListener() returns NULL and the
attempt to register the listener would crash.

Fix by ignoring the setting in that case.  The documentation already
says that it only has an effect if perf support is present, and we
already did the same for older LLVM versions that lacked support.

No field reports, unsurprisingly for an obscure developer-oriented
setting.  Noticed in passing while working on commit 1a28b4b4.

Backpatch-through: 14
Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA%2BhUKGJgB6gvrdDohgwLfCwzVQm%3DVMtb9m0vzQn%3DCwWn-kwG9w%40mail.gmail.com

src/backend/jit/llvm/llvmjit.c

index 9b599d1138054a5374bc0cacc583d7ea622416ed..c6079330544c12c98d33210e43bb8ee64eb6acce 100644 (file)
@@ -1191,7 +1191,8 @@ llvm_create_object_layer(void *Ctx, LLVMOrcExecutionSessionRef ES, const char *T
    {
        LLVMJITEventListenerRef l = LLVMCreatePerfJITEventListener();
 
-       LLVMOrcRTDyldObjectLinkingLayerRegisterJITEventListener(objlayer, l);
+       if (l)
+           LLVMOrcRTDyldObjectLinkingLayerRegisterJITEventListener(objlayer, l);
    }
 
    return objlayer;