Remove useless flag PVC_INCLUDE_CONVERTROWTYPES.

This was introduced in the SJE patch (fc069a3a6), but it doesn't
do anything because pull_var_clause() never tests it.  Apparently
it snuck in from somebody's private fork.  Remove it again, but
only in HEAD -- seems best to let it be in v18.

Author: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/70008c19d22e3dd1565ca57f8436c0ba@postgrespro.ru

diff --git a/src/backend/optimizer/path/equivclass.c b/src/backend/optimizer/path/equivclass.c
index a4fcfcc86c8032b90a105eac83c6dd8b170d4a69..e3697df51a244ca3b63eec3414012703288686f3 100644 (file)
--- a/src/backend/optimizer/path/equivclass.c
+++ b/src/backend/optimizer/path/equivclass.c
@@ -1007,8 +1007,7 @@ find_computable_ec_member(PlannerInfo *root,
        exprvars = pull_var_clause((Node *) exprs,
                                                           PVC_INCLUDE_AGGREGATES |
                                                           PVC_INCLUDE_WINDOWFUNCS |
-                                                          PVC_INCLUDE_PLACEHOLDERS |
-                                                          PVC_INCLUDE_CONVERTROWTYPES);
+                                                          PVC_INCLUDE_PLACEHOLDERS);
 
        setup_eclass_member_iterator(&it, ec, relids);
        while ((em = eclass_member_iterator_next(&it)) != NULL)

diff --git a/src/include/optimizer/optimizer.h b/src/include/optimizer/optimizer.h
index 485f641b3b47f19e15738da06491179835a96d0e..3d27a0196094919d470b398737707d22384fa561 100644 (file)
--- a/src/include/optimizer/optimizer.h
+++ b/src/include/optimizer/optimizer.h
@@ -193,8 +193,6 @@ extern SortGroupClause *get_sortgroupref_clause_noerr(Index sortref,
                                                                                         * output list */
 #define PVC_RECURSE_PLACEHOLDERS       0x0020  /* recurse into PlaceHolderVar
                                                                                         * arguments */
-#define PVC_INCLUDE_CONVERTROWTYPES    0x0040  /* include ConvertRowtypeExprs in
-                                                                                        * output list */
 
 extern Bitmapset *pull_varnos(PlannerInfo *root, Node *node);
 extern Bitmapset *pull_varnos_of_level(PlannerInfo *root, Node *node, int levelsup);