Remove redundant assignment in CreateWorkExprContext
authorJeff Davis <jdavis@postgresql.org>
Wed, 14 Jan 2026 20:01:36 +0000 (12:01 -0800)
committerJeff Davis <jdavis@postgresql.org>
Wed, 14 Jan 2026 20:01:36 +0000 (12:01 -0800)
In CreateWorkExprContext(), maxBlockSize is initialized to
ALLOCSET_DEFAULT_MAXSIZE, and it then immediately reassigned,
thus the initialization is a redundant.

Author: Andreas Karlsson <andreas@proxel.se>
Reported-by: Chao Li <lic@highgo.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/83a14f3c-f347-4769-9c01-30030b31f1eb@gmail.com

src/backend/executor/execUtils.c

index cc3c5de71eb2cb709ca3e3225e978dc4ec2f274b..a7955e476f903b4afbbf43e35221531deda49fff 100644 (file)
@@ -321,7 +321,7 @@ CreateExprContext(EState *estate)
 ExprContext *
 CreateWorkExprContext(EState *estate)
 {
-   Size        maxBlockSize = ALLOCSET_DEFAULT_MAXSIZE;
+   Size        maxBlockSize;
 
    maxBlockSize = pg_prevpower2_size_t(work_mem * (Size) 1024 / 16);