Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Oct 2025 16:32:06 +0000 (12:32 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Oct 2025 16:32:06 +0000 (12:32 -0400)
commit9f9a04368f8055c1851f5071add393b380d1cc52
treebaee97df7fac1af7bf4c64065878ad3db013865e
parent798b19d27b28e6dec3ae5134d396882d3197dfe8
Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf.

These two functions expect there to be room to insert another item
in the FreePageBtree's array, but their assertions were too weak
to guarantee that.  This has little practical effect granting that
the callers are not buggy, but it seems to be misleading late-model
Coverity into complaining about possible array overrun.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us
Backpatch-through: 13
src/backend/utils/mmgr/freepage.c