Skip to content

Renamed fields for consistency#403

Merged
Seluj78 merged 4 commits intodevfrom
chore/dt-fields-rename
Nov 5, 2020
Merged

Renamed fields for consistency#403
Seluj78 merged 4 commits intodevfrom
chore/dt-fields-rename

Conversation

@Seluj78
Copy link
Copy Markdown
Owner

@Seluj78 Seluj78 commented Nov 5, 2020

Closes #368

Reasoning is, none is a timestamp, they're all datetimes

On this PR @supalarry, I renamed the following fields:

User:

  • date_joined -> dt_joined
  • date_lastseen -> dt_lastseen

Message:

  • timestamp -> dt_sent
  • seen_timestamp -> dt_seen

Image:

  • timestamp -> dt_added

Can you please change those where you use them in the frontend and push it on this PR ? Once done we'll test and merge

@Seluj78 Seluj78 added Backend Anything that touches the backend part of the app Backlog Something to be done but isn't as important labels Nov 5, 2020
@Seluj78 Seluj78 requested a review from supalarry November 5, 2020 13:59
@Seluj78 Seluj78 self-assigned this Nov 5, 2020
@Seluj78 Seluj78 force-pushed the chore/dt-fields-rename branch from 0d96279 to 3dbe05e Compare November 5, 2020 14:22
@Seluj78 Seluj78 merged commit bd207a2 into dev Nov 5, 2020
@Seluj78 Seluj78 deleted the chore/dt-fields-rename branch November 5, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Anything that touches the backend part of the app Backlog Something to be done but isn't as important

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename all incorrect fields named timestamp that are datetimes

2 participants