Add support for Spark 3.1 and 3.2 #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
reviewed
Nov 22, 2021
masseyke
reviewed
Nov 22, 2021
Member
|
@elasticmachine update branch |
masseyke
reviewed
Dec 7, 2021
masseyke
approved these changes
Dec 7, 2021
Member
masseyke
left a comment
There was a problem hiding this comment.
Looks good to me. I built it out and tried it manually in a yarn cluster -- didn't find any problems.
|
Why |
Member
|
It looks like a mistake. It looks like we're pulling in both 3.0.1 and 3.2.0. I believe the 3.2.0 ones are taking precedence (b/c we're able to use 3.2-only features). But we need to sort that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark changed the internal implementation of the CompactibleFileStreamLog which caused issues when trying to upgrade. We simply support both the old and new version by implementing both required methods (old and new) and allowing them to be resolved at runtime as needed.