Skip to content

Java: pick an arbitrary representative location when an entity has many candidate locations.#10093

Merged
smowton merged 5 commits into
github:mainfrom
smowton:smowton/feature/java-singular-locations
Aug 22, 2022
Merged

Java: pick an arbitrary representative location when an entity has many candidate locations.#10093
smowton merged 5 commits into
github:mainfrom
smowton:smowton/feature/java-singular-locations

Conversation

@smowton
Copy link
Copy Markdown
Contributor

@smowton smowton commented Aug 18, 2022

No description provided.

@smowton smowton requested a review from a team as a code owner August 18, 2022 11:03
@github-actions github-actions Bot added the Java label Aug 18, 2022
@smowton smowton force-pushed the smowton/feature/java-singular-locations branch from 1009e22 to 17dd1f6 Compare August 18, 2022 13:29
aschackmull
aschackmull previously approved these changes Aug 18, 2022
Copy link
Copy Markdown
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@smowton
Copy link
Copy Markdown
Contributor Author

smowton commented Aug 19, 2022

@aschackmull I needed to do some join-order engineering after this perturbed InlineExpectationsTest into a bad enough order that tests were timing out.

Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me!

Copy link
Copy Markdown
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QL-for-QL 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants