Skip to content

Fix ignored #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 3 commits into from
Jan 22, 2023
Merged

Fix ignored #1545

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ada83a
Add test_ignored_items_reported
Lightborne Jan 21, 2023
2ddb604
Add test to verify GitCommandError is raised when check-ignore is run…
Lightborne Jan 21, 2023
df4dabb
Raise exception if return code from check-ignore is not 1
Lightborne Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Raise exception if return code from check-ignore is not 1
  • Loading branch information
@Lightborne
Lightborne committed Jan 21, 2023
commit df4dabb17c4e83c580d515894dbf7d57912ee554
11 changes: 9 additions & 2 deletions git/repo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,8 +873,15 @@ def ignored(self, *paths: PathLike) -> List[str]:
"""
try:
proc: str = self.git.check_ignore(*paths)
except GitCommandError:
return []
except GitCommandError as err:
# If return code is 1, this means none of the items in *paths
# are ignored by Git, so return an empty list. Raise the
# exception on all other return codes.
if err.status == 1:
return []
else:
raise

return proc.replace("\\\\", "\\").replace('"', "").split("\n")

@property
Expand Down