Feat: adjust fields for ECS compatibility #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzone
reviewed
Nov 16, 2021
karenzone
reviewed
Nov 16, 2021
karenzone
reviewed
Nov 16, 2021
| "command" => "echo '¡Hola!'", | ||
| "host" => "deus-ex-machina" | ||
| } | ||
| ----- |
There was a problem hiding this comment.
Thanks for adding these examples. Nice!
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
kares
added a commit
to kares/logstash-input-pipe
that referenced
this pull request
Nov 18, 2021
kares
added a commit
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously plugin was setting the top level
commandandhostfields for every event (which aren't ECS compliant).There's a change in behavior to not override fields if they exists in the decoded payload (e.g. no longer force the
hostfield if such a field is decoded from the command's output).Also avoid an unnecessary
undefined methodclose' for nil` when a different thread stops the plugin.Plugin changes are similar to it's input exec cousin: logstash-plugins/logstash-input-exec#28