bpo-43144: Mark unicodedata's test_normalization as requiring network#24650
Merged
Conversation
Co-authored-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
corona10
approved these changes
Feb 26, 2021
Contributor
|
Thanks @ammaraskar for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Thanks @ammaraskar for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-24655 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 26, 2021
…pythonGH-24650) Co-authored-by: Arkadiusz Miśkiewicz <arekm@maven.pl> (cherry picked from commit c6ccdfb) Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
Contributor
|
Sorry, @ammaraskar and @corona10, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Feb 26, 2021
Member
|
3.8 does not have |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…pythonGH-24650) Co-authored-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is missing a requires network despite the fact that it uses
open_urlresourcewhich can cause failures on systems that aren't actually connected to the network.Converted from a bpo patch to a github pull request on behalf of Arkadiusz.
https://bugs.python.org/issue43144