bpo-34551: Remove redundant store#9009
Conversation
The assignment of i/2 to nk is redundant because on this code path, nk is already the size of the dictionary, and i is already twice the size of the dictionary. I've replaced the store with an assertion that i/2 is nk.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
Re: CLA not signed: I am a Facebook employee and we have a company-wide CLA. I'll investigate what incantations I need to perform to ensure that the bot stops flagging me. |
|
I've signed the CLA and commentary on the associated issue indicates that the change is safe; could I please get the "CLA not signed" tag removed? Thanks! |
|
As an outsider, it looks to me like the "skip news" label would apply to this PR and that it would resolve the failing check. Is that right? |
|
Any chance someone could approve this PR? |
|
Merged based on discussion on the issue. |
|
Thank you, @ericlippert. |
|
@ambv: Please replace |
The assignment of i/2 to nk is redundant because on this code path, nk is already the size of the dictionary, and i is already twice the size of the dictionary. I've replaced the store with an assertion that i/2 is equal to nk.
https://bugs.python.org/issue34551