Skip to content

Translating tutorial/datastructure.po #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
awecx merged 3 commits into from
May 3, 2020
Merged

Translating tutorial/datastructure.po #1081

awecx merged 3 commits into from
May 3, 2020

Conversation

@Soteded
Copy link
Contributor

@Soteded Soteded commented Dec 13, 2019

Fix #1071

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Dec 13, 2019
@awecx awecx self-assigned this Dec 13, 2019
@awecx awecx removed the NEED REVIEWER This PR needs a reviewer :) label Dec 13, 2019
awecx
awecx suggested changes Dec 13, 2019
View reviewed changes
Copy link

@awecx awecx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette PR.
Je n'ai pas vérifié chacune des espaces mais si ça vient de padpo, je fais confiance.
Je t'ai mis quelques remarques, n'oublie pas de réindenter le fichier après l'avoir re-modifié.

@awecx
Copy link

awecx commented Dec 17, 2019

Ping :-)

@Seluj78
Copy link
Collaborator

Seluj78 commented Feb 4, 2020

Ping @Soteded

deronnax and others added 2 commits May 3, 2020 13:38
@deronnax @awecx
Apply suggestions from code review
a7420ac 
Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
@deronnax
Merge branch '3.8' into tutorialDatastructures
a095c68
@deronnax deronnax requested a review from awecx May 3, 2020 15:39
@deronnax
Copy link
Collaborator

deronnax commented May 3, 2020 •
edited
Loading

Ça fait 6 mois que la PR pourrie sur pied. Pas de chance, entre temps Christophe a fait une passe sur le fichier, et une fois ses contributions intégrées, il ne reste plus que 3 changements : 1 tiret te 2 espaces insécables.

@awecx awecx merged commit a546ff3 into python:3.8 May 3, 2020
@awecx
Copy link

awecx commented May 3, 2020

Merci @Soteded et @deronnax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deronnax deronnax deronnax left review comments

+1 more reviewer

@awecx awecx awecx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Soteded Soteded

@awecx awecx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Je travaille sur tutorial/datastructures.po

4 participants

@Soteded @awecx @Seluj78 @deronnax