Revue de install/index.po #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deronnax
reviewed
Apr 3, 2020
Collaborator
deronnax
left a comment
There was a problem hiding this comment.
Belle reprise en main, bravo. La version d'avant était à s'arracher les cheveux. Par contre, as-tu vu que c'est une version obsolète et que la version "mainstream" est installing/index.po ?
christopheNan
commented
Apr 3, 2020
Contributor
Author
christopheNan
left a comment
There was a problem hiding this comment.
Oui, j'ai bien vu que c'est obsolète. Mais, c'est intéressant et je suis tombé dessus en parcourant padpo.ignore (une mine ce fichier !).
Collaborator
|
Merci d'avoir pris en compte mes retours <3 |
deronnax
reviewed
Apr 3, 2020
deronnax
approved these changes
Apr 3, 2020
Collaborator
|
oups la CI est pas finie. J'ai été un peu trop rapide sur le merge. J'espère que la CI passera, sinon ça signifie master cassé |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.