Skip to content

Translated errno #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopheNan merged 22 commits into from
Jan 15, 2019
Merged

Translated errno #537

christopheNan merged 22 commits into from
Jan 15, 2019

Conversation

@Dygouin
Copy link
Contributor

@Dygouin Dygouin commented Jan 11, 2019

No description provided.

christopheNan
christopheNan reviewed Jan 11, 2019
View reviewed changes
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques propositions

christopheNan and others added 16 commits January 12, 2019 00:15
@christopheNan @Dygouin
Update library/errno.po
1f28a68 
Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
3fe5c8d 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
d33833d 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
42627bf 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
f0f4c6c 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
16c236e 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
4a067c8 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
04886b8 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
8f3ef05 
Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
6244587 
Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
3c8e031 
Update with suggestions

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
2e22bac 
Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Update library/errno.po
400e20a 
Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@christopheNan @Dygouin
Apply suggestions from code review
480a7cb 
Merci pour le code review

Co-Authored-By: DeltaAlphaIotaLamdaAlphaNu <gouindylan7@gmail.com>
@Dygouin
corrections du log
9ffbd7f
@Dygouin
corrections du log v2
d6c1b19
@Dygouin
Copy link
Contributor Author

Dygouin commented Jan 12, 2019

yay les checks sont passés

Seluj78
Seluj78 requested changes Jan 12, 2019
View reviewed changes
Seluj78
Seluj78 requested changes Jan 12, 2019
View reviewed changes
library/errno.po Outdated
#: ../Doc/library/errno.rst:123
msgid "No such device"
msgstr ""
msgstr "Périphérique inexistant"
Copy link
Collaborator

@Seluj78 Seluj78 Jan 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est ce que il y aurait pas un autre mot pour device? Car je suppose que cette erreur fait référence à /dev/ et on y trouve des devices physiques comme virtuels et a mon sens périphérique fait trop référence a un clavier par exemple

Copy link
Contributor Author

@Dygouin Dygouin Jan 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

système, appareil, (dispositif) je préfere le 3ème

Copy link
Contributor

@christopheNan christopheNan Jan 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Dispositif" me semble bien.

library/errno.po Outdated
#: ../Doc/library/errno.rst:168
msgid "No space left on device"
msgstr ""
msgstr "Plus de place sur le périphérique"
Copy link
Collaborator

@Seluj78 Seluj78 Jan 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pareil ici, périphérique me semble etrange utilié ici puisqu'on fait référence a un disque (peut importe son type) ou alors on fait référence a la machine en elle meme (typiquement sur macos, lorsque un home est full (a 42 par exemple) on a cette erreur.)

Copy link
Contributor Author

@Dygouin Dygouin Jan 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dispositif est peut être mieux?

@Dygouin
Copy link
Contributor Author

Dygouin commented Jan 12, 2019

Du coup j'attend tes réponses avant de repush

@Seluj78
Copy link
Collaborator

Seluj78 commented Jan 12, 2019

@DeltaAlphaIotaLamdaAlphaNu responses a ? :)

@Dygouin
Copy link
Contributor Author

Dygouin commented Jan 12, 2019

Les requests que j'ai laissée ouvertes

@Seluj78
Copy link
Collaborator

Seluj78 commented Jan 14, 2019

@DeltaAlphaIotaLamdaAlphaNu tu as tes reponses 👍

@Dygouin
Copy link
Contributor Author

Dygouin commented Jan 14, 2019

@Seluj78 dès que je suis à la maison je te fais le dernier push pour que tu puisses me review (je suis a 42 et je galère pour push d'ici).

@Dygouin
Copy link
Contributor Author

Dygouin commented Jan 14, 2019

Ça devrait être bon là

Seluj78
Seluj78 requested changes Jan 14, 2019
View reviewed changes
Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La CI passe 👌

@christopheNan christopheNan merged commit dfff534 into python:3.7 Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Seluj78 Seluj78 Seluj78 approved these changes

+1 more reviewer

@christopheNan christopheNan christopheNan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dygouin @Seluj78 @christopheNan