Skip to content

Conversation

@Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Nov 17, 2019

No description provided.

@Seluj78
Copy link
Contributor Author

Seluj78 commented Nov 17, 2019

@ncoghlan you seem to be one of the last editors of that file, what are your thoughts ? Should I continue doing that for the whole file ? Is it not necessary ?

When translating that file to French, one of our new translator left it like this but they need to be spaced out

@Seluj78
Copy link
Contributor Author

Seluj78 commented Nov 17, 2019

@birkenfeld you seem to be the one who wrote those lines, 12 years ago 😱 What are your thoughts ?

@birkenfeld
Copy link
Member

I'll show up as the original author of all docs files that are old enough, since I committed the conversion from TeX to rst/Sphinx. But most of the content is much older still :)

I'm neutral in whether this is a good idea; historically we have frowned upon such wholesale minor style changes.

@taleinat
Copy link
Contributor

I'm neutral in whether this is a good idea; historically we have frowned upon such wholesale minor style changes.

That's true. However, the Helping with Documentation section in the Developer's Guide currently seems to support making such doc fixes and minor improvements. Selected quotes:

Issues vary from typos to unclear documentation and items lacking documentation."

Simple typos don’t require issues of their own, but, instead, submit a pull request directly.

@taleinat
Copy link
Contributor

In this specific case, this change will be rejected for two reasons:

  1. The em-dashes used here should indeed not be surrounded by spaces. The current form is correct!
  2. These distutils docs are considered legacy, so to my understanding they should only be changed to address major issues.

@taleinat taleinat closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants